#2726 closed Bug (fixed)
Bug in trcsink
Reported by: | aumont | Owned by: | aumont |
---|---|---|---|
Priority: | low | Milestone: | |
Component: | TOP | Version: | trunk |
Severity: | major | Keywords: | |
Cc: |
Description
Context
trcsink handles the sinking of particles. In case, sinking speed is high enough so that the CFL criterion is violated, a time splitting approach is used. The number of necesseray iterations is automatically computed and may be capped at a maximum value to avoid a very high computing cost in specific cases.
Analysis
Two bugs have been identified :
1) the number of iteration is incorrectly computed. The INT instruction is used which is rounding the number of iterations to the nearest lower integer. INT() + 1 should be used instead.
2) The time splitting approach is inactive. No iteration on the number of necessary iterations is performed. Sinking speeds are reduced instead when necessary. This is equivalent to specifying nitermax to 1.
Fix
This module should be rewritten correcting for the bugs listed above.
...
Commit History (2)
Changeset | Author | Time | ChangeLog |
---|---|---|---|
15325 | cetlod | 2021-10-04T14:07:47+02:00 | bugfix in TOP/TRP/trcsink.F90, see ticket #2726 |
15291 | aumont | 2021-09-27T14:38:34+02:00 | bug fix #2726 |
Change History (2)
comment:1 Changed 3 years ago by aumont
- Resolution set to fixed
- Status changed from new to closed
comment:2 Changed 3 years ago by cetlod
In 15325:
In 15291: