Argument var_nodims when calling oasis3-mct_3.0 oasis_def_var routine

[valcke]

When calling oasis_def_var, the 4th argument var_nodims is (2,0) whereas it should be (2,1). It has no impact for now but his si not clean (and maybe will have an impact with further oasis3-mct version when bundle fields will be supported.

[frrh]

Hi Sophie & Seb,

I'm just adding a comment here because I've been testing NEMO with OASIS3-MCT version 4.0.

There are appear to be two issues with the NEMO code in CPL_OASIS3.F90 which are at odds with vn4.0 of the coupler.

The first is the use of var_nodims which you mention in the description of this ticket.

In the code, it's written as a literal argument (/2,0/) but presumably now wants to be made more flexible by using
an array, say, nemo_var_dims(1) = 2 and nemo_var_dims(2) = nbundle to cater for bundle fields
even if nbundle just defaults to 1.

The second issue actually causes a compilation failure because ishape is dimensioned as (2,2) and
sets the values thus

         ishape(:,1) = (/ 1, nlei-nldi+1 /)
         ishape(:,2) = (/ 1, nlej-nldj+1 /) 

That was fine for OASIS3-MCT vn3.0 (or at least it worked OK because the psmile interface
was not fussy about the format of the array as long as it got the right number of elements
in the right order).
But at vn4.0 the psmile interface demands that ishape is a 1D array, so we have to
dimension ishape(1:4) and set:

  ishape(1) = 1
  ishape(2) = nlei-nldi+1
  ishape(3) = 1
  ishape(4) = nlej-nldj+1

I was originally going to open my own ticket, but then I found this one, so I guess these
things are best addressed by this ticket.

Regards,

Richard

[smasson]

done in the trunk, see [10404]