New URL for NEMO forge!   http://forge.nemo-ocean.eu

Since March 2022 along with NEMO 4.2 release, the code development moved to a self-hosted GitLab.
This present forge is now archived and remained online for history.
#1238 (Bug in volume calculation for tendency diagnostics) – NEMO

Opened 10 years ago

Closed 10 years ago

#1238 closed Bug (fixed)

Bug in volume calculation for tendency diagnostics

Reported by: guziy Owned by: nemo
Priority: low Milestone:
Component: OCE Version: v3.4
Severity: Keywords:
Cc:

Description

In the file dev_v3_4_STABLE_2012/NEMOGCM/NEMO/OPA_SRC/TRD/trdicp.F90, subroutine trd_icp_init,
tvolume is not calculated correctly.

What is currently in the code

      tvolt = 0._wp
      DO jk = 1, jpkm1
         tvolt = SUM( e1e2t(:,:) * fse3t(:,:,jk) * tmask(:,:,jk) * tmask_i(:,:) )
      END DO

Proposed fix:

      tvolt = 0._wp
      DO jk = 1, jpkm1
         tvolt = tvolt + SUM( e1e2t(:,:) * fse3t(:,:,jk) * tmask(:,:,jk) * tmask_i(:,:) )
      END DO

Commit History (2)

ChangesetAuthorTimeChangeLog
4606gm2014-03-28T11:47:14+01:00

#1238 - v3.4_STABLE: correct the volume calculation for tendency diagnostics

4605gm2014-03-28T11:46:11+01:00

#1238 - trunk: correct the volume calculation for tendency diagnostics

Change History (1)

comment:1 Changed 10 years ago by gm

  • Resolution set to fixed
  • Status changed from new to closed

Thanks for reporting this issue

Solved in both NEMO_v3_4_STABLE and v3.6 beta (trunk). see revision 4605 and 4606

Gurvan

Note: See TracTickets for help on using tickets.