Version 2 (modified by rblod, 14 years ago) (diff) |
---|
Last edited Timestamp?
For completion by the Sci/Tech/Code? reviewer
Reviewer: Rachid Benshila
- basically nothing to improve in term of implementation
- style off additions is ok, some changes to do in term of cosmetic in old bdy routines (see attached routines)
- general observation : we should use one array being either bdytmask either obctmask, it would avoid some duplication (solmat, sshwzw)
- general observation : we should use fldread for bdydta (and obcdta)
Ticket Details, Documentation and Code changes
Do you understand the area of code being altered and the reasoning why it is being altered? | YES |
Do the proposed code changes correspond with the stated reason for the change? | YES |
Is the in-line documentation accurate and sufficient? | YES |
Do the code changes comply with NEMO coding standards? | YES |
Is the Ticket documented with sufficient detail for others to understand the impact of the change? | YES |
Does any corresponding external documentation require updating? | YES |
If yes, which docs and have the updates been drafted? | is underway |
Are namelist changes required for this change? | YES |
If yes, have they been done? | NA |
Has a completed Ticket Summary template been appended to the ticket to aid code reviews | YES |
Does this summary correspond with your understanding of the full ticket? | YES |
Ticket, Documentation and Code comments
Add specific Ticket, Documentation and code comments here
Testing
Has the NVTK and other jobs been tested with this change? | NA |
Have the required bit comparability tests been run? | NA |
Can this change be shown to have a null impact? (if option not selected) | YES |
If no, is reason for the change valid/understood? | NA |
If no, ensure that the ticket details the impact this change will have on model configurations . | NA |
Is this change expected to preserve all diagnostics? | NO |
If no, is reason for the change valid/understood? | YES |
Are there significant changes in run time/memory? | NO |
Testing Comments
Add specific testing comments here
Add specific testing comments here
Code Review
Do the code changes comply with NEMO coding standards? | YES |
Are code changes consistent with the design of NEMO? | YES |
Is the code free of unwanted TABs? | YES |
Has the code been wholly (100%) produced by NEMO developers working on NEMO? | YES |
If no, ensure collaboration agreement has been added to the ticket keywords |
Add specific code comments or suggested alterations here.
Review Summary
Add summary here
Approval for the trunk
YES (waiting for the documentation)
The code reviewer may approve the change for the NEMO trunk when:
- their requests/comments have been addressed satisfactorily.
- the above check-list has been completed.
or the code reviewer may choose to reject & assign the change back to the code author.
Attachments (1)
- BDY_ROUTINES.tar (142.0 KB) - added by rblod 14 years ago.
Download all attachments as: .zip