Changeset 2704 for XIOS2/dev/hshepherd/reduce_output_log/src/server.cpp

Timestamp:

01/17/25 15:18:37 (3 weeks ago)

Author:

hshepherd

Message:

Port across changes from the patching - Not yet tested

File:

• XIOS2/dev/hshepherd/reduce_output_log/src/server.cpp (modified) (11 diffs)

XIOS2/dev/hshepherd/reduce_output_log/src/server.cpp

@@ -14 +14 @@
 #include "timer.hpp"
 #include "mem_checker.hpp"
+#include "timestats.hpp"
 #include "event_scheduler.hpp"
 #include "string_tools.hpp"
@@ -34 +35 @@
     bool CServer::finished=false ;
     bool CServer::is_MPI_Initialized ;
+    bool CServer::writeLogFromRank;
     CEventScheduler* CServer::eventScheduler = 0;
 
@@ -397 +399 @@
       if (rank==0) isRoot=true;
       else isRoot=false;
+
+      writeLogFromRank = determineWriteLogFromRank();
       
       eventScheduler = new CEventScheduler(intraComm) ;
     }
 
+    std::vector<double> CServer::collate_timings(std::string timing_param)
+    {
+      int myrank, comm_size;
+      MPI_Comm_rank(intraComm, &myrank);
+      MPI_Comm_size(intraComm, &comm_size);
+
+      std::vector<double> collated_results;
+      MPI_Barrier(intraComm);
+      if (myrank == 0) {
+        double recv_val = 0.;
+        collated_results.push_back(CTimer::get(timing_param).getCumulatedTime());
+        for (int i = 1; i < comm_size; i++) {
+          MPI_Recv(&recv_val, 1, MPI_DOUBLE, i, 0, intraComm, MPI_STATUS_IGNORE);
+          collated_results.push_back(recv_val);
+        }
+      } else {
+        double snd_val = CTimer::get(timing_param).getCumulatedTime();
+        MPI_Send(&snd_val, 1, MPI_DOUBLE, 0, 0, intraComm);
+      }
+      MPI_Barrier(intraComm);
+      return collated_results;
+    }
+
+    void CServer::present_collated_timings(void)
+    {
+      std::vector<double> processing_times = collate_timings("Process events");
+      std::vector<double> xios_server_times = collate_timings("XIOS server");
+      std::vector<double> ratio = percentage_ratio_vec_double(processing_times, xios_server_times);
+      // writeLogFromRank gives the lead rank for L1 servers and server pools
+      if (getRank() == 0) {
+        int n_ranks;
+        MPI_Comm_size(intraComm, &n_ranks);
+        report(0) << " Performance metrics across the intraComm communicator for this rank." << endl;
+        report(0) << "     There are " << n_ranks << " ranks in this intraComm" << endl;
+        write_summary_timings(processing_times, "Processing events");
+        write_summary_timings(ratio, "Ratio (Percentage)");
+      }
+    }
+      
+
+    void CServer::write_summary_timings(std::vector<double>& collated_results,
+                                        std::string results_label)
+    {
+      report(0) << "  " << results_label << " average " << calc_mean_double(collated_results) << endl;
+      report(0) << "  " << results_label << " std dev " << calc_std_double(collated_results) << endl;
+      report(0) << "  " << results_label << " min " << calc_min_double(collated_results) << endl;
+      report(0) << "  " << results_label << " max " << calc_max_double(collated_results) << endl;
+    }
+  
+
     void CServer::finalize(void)
     {
+      present_collated_timings();
+      MPI_Barrier(intraComm);
+
       CTimer::get("XIOS").suspend() ;
      
@@ -430 +487 @@
         else MPI_Finalize() ;
       }
+
+      if (CXios::reduceLogFiles) report(0) << "Performance summary from the first rank in this intraComm." << endl;
+
       report(0)<<"Performance report : Time spent for XIOS : "<<CTimer::get("XIOS server").getCumulatedTime()<<endl  ;
       report(0)<<"Performance report : Time spent in processing events : "<<CTimer::get("Process events").getCumulatedTime()<<endl  ;
@@ -907 +967 @@
     }
 
+    bool CServer::determineWriteLogFromRank()
+    {
+      // Write from rank zero of each intracomm, which will be the rank of
+      // the lead level one and two servers
+      if (!CXios::reduceLogFiles) return true;
+      if (getRank() == 0) return true;
+      return false;
+    }
+
     /*!
     * \brief Open a file stream to write the info logs
@@ -915 +984 @@
     void CServer::openInfoStream(const StdString& fileName)
     {
-      std::filebuf* fb = m_infoStream.rdbuf();
-      openStream(fileName, ".out", fb);
-
-      info.write2File(fb);
-      report.write2File(fb);
+      if (writeLogFromRank)
+      {
+        std::filebuf* fb = m_infoStream.rdbuf();
+        openStream(fileName, ".out", fb);
+
+        info.write2File(fb);
+        report.write2File(fb);
+      }
     }
 
@@ -925 +997 @@
     void CServer::openInfoStream()
     {
-      info.write2StdOut();
-      report.write2StdOut();
+      if (writeLogFromRank)
+      {
+        info.write2StdOut();
+        report.write2StdOut();
+      }
     }
 
@@ -932 +1007 @@
     void CServer::closeInfoStream()
     {
-      if (m_infoStream.is_open()) m_infoStream.close();
+      if (writeLogFromRank)
+      {
+        if (m_infoStream.is_open()) m_infoStream.close();
+      }
     }
 
@@ -943 +1021 @@
     void CServer::openErrorStream(const StdString& fileName)
     {
-      std::filebuf* fb = m_errorStream.rdbuf();
-      openStream(fileName, ".err", fb);
-
-      error.write2File(fb);
+      if (writeLogFromRank)
+      {
+        std::filebuf* fb = m_errorStream.rdbuf();
+        openStream(fileName, ".err", fb);
+
+        error.write2File(fb);
+      }
     }
 
@@ -952 +1033 @@
     void CServer::openErrorStream()
     {
-      error.write2StdErr();
+      if (writeLogFromRank)
+      {
+        error.write2StdErr();
+      }
     }
 
@@ -958 +1042 @@
     void CServer::closeErrorStream()
     {
-      if (m_errorStream.is_open()) m_errorStream.close();
+      if (writeLogFromRank)
+      {
+        if (m_errorStream.is_open()) m_errorStream.close();
+      }
     }
 }