Opened 11 years ago

Closed 11 years ago

#101 closed defect (fixed)

GetInputRestartFiles not correct when Restarts_OverRule=n

Reported by: omamce Owned by: labetoulle
Priority: major Milestone: libIGCM_v2.0
Component: system Version: 2.0
Keywords: Cc:

Description

IGCM_comp_GetInputRestartFiles, from line 711 (libIGCM 2.0 rc2) in libIGCM_comp.

The function tries to find the relevant tar file to extract the restarts. It set the name of the tar file only once : it is set for the first component, and never change. All restarts are extracted from this file.

It is ok when config_Restarts_OverRule=y : all restarts are in the same tar file. When config_Restarts_OverRule=n, the restarts of each component may be in different tar files.

The idea could be to unset IsMatching? before line 711 if config_Restarts_OverRule=n.

Olivier

Change History (2)

comment:1 Changed 11 years ago by labetoulle

  • Owner changed from somebody to labetoulle
  • Status changed from new to assigned

Since IsMatching is declared as a local variable (through typeset), it might be better not to unset it but to initialize it to ${NULL_STR}, as well as TarFileFound, near line 661 (in the else part of « if [ "${config_Restarts_OverRule}" = "y" ] »).

comment:2 Changed 11 years ago by labetoulle

  • Resolution set to fixed
  • Status changed from assigned to closed

Correction done, see r778.

Note: See TracTickets for help on using tickets.