Changes between Version 2 and Version 3 of WorkViovy

Timestamp:

2010-07-21T19:39:21+02:00 (14 years ago)

Author:

nicolasviovy

Comment:

--

WorkViovy

@@ -12 +12 @@
 
 Constraints now depend on soil water
+
+== Work on convergence with sönke code ==
+
+1/ a problem when using the old photosynthesis. In diffuco_trans_co2 there where a divide by gstop not protected by a test gstop>0
+we have to replace:
+        ''DO inia=1,nia
+
+           !
+
+           iainia=index_assi(inia)
+
+           !
+
+           rveget(iainia,jv) = 1./gstop(iainia)
+
+           !
+
+        ENDDO''
+
+by
+        ''DO inia=1,nia
+
+           !
+
+           iainia=index_assi(inia)
+
+           !
+
+           IF (gstop(iainia) > min_sechiba) THEN
+
+              rveget(iainia,jv) = 1./gstop(iainia)
+
+           ELSE
+
+               rveget(iainia,jv) = 1e5
+
+            ENDIF
+
+           !
+
+        ENDDO''
+
+and''
+
+     DO inia=1,nia
+
+          !
+
+          iainia=index_assi(inia)
+
+          !
+
+          ! rstruct is the difference between rtot (=1./gstot) and rveget
+
+          !
+
+          rstruct(iainia,jv) = 1./gstot(iainia,jv) - &
+
+               rveget(iainia,jv)
+
+          !
+
+        ENDDO''
+
+by
+       ''DO inia=1,nia
+
+          !
+
+          iainia=index_assi(inia)
+
+          !
+
+          ! rstruct is the difference between rtot (=1./gstot) and rveget
+
+          !
+
+          IF (gstot(iainia,jv) > min_sechiba) THEN
+
+          rstruct(iainia,jv) = 1./gstot(iainia,jv) - &
+
+               rveget(iainia,jv)
+
+          ELSE
+
+            rstruct(iainia,jv) =0
+
+         ENDIF
+
+          !
+
+        ENDDO''
+
+
+2/ A problem in the first call to npp_calc. There is a line where scal = 1./ind(i,j) * cn_ind(i,j) whereas ind and cn_ind are not wet defined (so set to 0)
+corrected by putting a return at the end of the initialisation block:
+IF (firstcall) THEN .....
+
+  firstcall= .FALSE.
+
+  RETURN
+
+ENDIF
+
+
+3/ Somethink which is probably very machine dependent but on titane whish is very very sensitive to precision problem (also when using simple precision) but anyway better to correct it:
+in stomate_season there is a calculation of rue_longterm
+  '' ! 
+
+   ! 14.1 longterm radiation use efficiency
+    !
+    DO j=2,nvm
+       WHERE(biomass(:,j,ileaf,icarbon)) .GT. min_stomate)
+           rue_longterm(:,j) =  ( rue_longterm(:,j) * ( one_year - dt ) + &
+                     gpp_daily(:,j) / (1. - exp(-0.5 * biomass(:,j,ileaf,icarbon)*sla(j))) * dt ) / (one_year)
+       ENDWHERE
+    ENDDO''
+in some case there is un FP error since (1. - exp(-0.5 * biomass(:,j,ileaf,icarbon)*sla(j))) * dt ) is probably near 0
+so I replaced the:
+''      WHERE(biomass(:,j,ileaf,icarbon)) .GT. min_stomate)
+''
+by 
+ ''   WHERE((1. - exp(-0.5 * biomass(:,j,ileaf,icarbon)*sla(j))) .GT. min_stomate)
+'' 
+