Changes between Version 1 and Version 2 of DevelopmentActivities/ORCHIDEE-MICT-IMBALANCE-P/Evaluation

Timestamp:

2015-08-24T10:20:20+02:00 (9 years ago)

Author:

mguimberteau

Comment:

--

DevelopmentActivities/ORCHIDEE-MICT-IMBALANCE-P/Evaluation

@@ -1 +1 @@
 = Evaluation =
+
+== Notes from M. Guimberteau ==
+
+=== 2015/08/24 ===
+
+* Bugs
+
+'''In thermosoil'''
+
+The variable SoilTemp should be in the almaoutput condition of the loop and related to ptn_pftmean and not ptn:
+
+Before in the code:
+
+
+{{{
+       IF ( .NOT. almaoutput ) THEN
+          CALL histwrite_p(hist_id, 'SoilTemp', kjit, ptn_pftmean, kjpindex*ngrnd, indexgrnd)                                                                                   
+          CALL histwrite_p(hist2_id, 'ptn', kjit, ptn, kjpindex*ngrnd, indexgrnd)                                                                                               
+       ELSE
+          CALL histwrite_p(hist2_id, 'SoilTemp', kjit, ptn, kjpindex*ngrnd, indexgrnd)                                                                                          
+          CALL histwrite_p(hist2_id, 'Qg', kjit, soilflx, kjpindex, index)
+          CALL histwrite_p(hist2_id, 'DelSurfHeat', kjit, surfheat_incr, kjpindex, index)
+          CALL histwrite_p(hist2_id, 'DelColdCont', kjit, coldcont_incr, kjpindex, index)
+       ENDIF
+    ENDIF
+
+}}}
+
+After corrections:
+
+{{{
+
+     IF ( hist2_id > 0 ) THEN
+       IF ( .NOT. almaoutput ) THEN
+          CALL histwrite_p(hist2_id, 'ptn_pftmean', kjit, ptn_pftmean, kjpindex*ngrnd, indexgrnd)
+       ELSE
+          CALL histwrite_p(hist2_id, 'SoilTemp', kjit, ptn_pftmean, kjpindex*ngrnd, indexgrnd)
+          CALL histwrite_p(hist2_id, 'Qg', kjit, soilflx, kjpindex, index)
+          CALL histwrite_p(hist2_id, 'DelSurfHeat', kjit, surfheat_incr, kjpindex, index)
+          CALL histwrite_p(hist2_id, 'DelColdCont', kjit, coldcont_incr, kjpindex, index)
+       ENDIF
+    ENDIF
+}}}
+
+'''In intersurf and ioipslctrl'''
+
+The variable ptn_snow_pftmean does not exist in the code anymore. The call histdef should be removed:
+
+{{{
+           CALL histdef(hist_id, 'ptn_snow_pftmean', 'Snow temperature,PFT-mean', 'K', &                                                                                        
+                & iim,jjm, hori_id, nsnow, 1, nsnow, snowax_id, 32,avescatter(6), dt,dw)
+}}}
+
+The variable soiltemp should be put outside the if (ok_explicitsnow) condition
+
+
+{{{
+              CALL histdef(hist_id, 'soiltemp','Soil temperature profile','K', &
+               & iim,jjm, hori_id, ngrnd, 1, ngrnd, solax_id, 32,avescatter(6),dt,dw)
+}}}
+
+The histdef high frequency of the variable ptn_pftmean is missing in SECHIBA_HISTLEVEL2 = 7 level:
+
+{{{
+               CALL histdef(hist2_id, 'ptn_pftmean', 'Soil temperature, PFT-mean','K', &
+                & iim,jjm, hori_id2, ngrnd, 1, ngrnd, solax_id, 32,avescatter2(7), dt,dw2)
+}}}
+
+
+----
+
 
 == Notes from F. Maignan ==