Changes between Version 37 and Version 38 of DevelopmentActivities/MergeOCN/Vuichard
- Timestamp:
- 2014-02-06T17:10:36+01:00 (10 years ago)
Legend:
- Unmodified
- Added
- Removed
- Modified
-
DevelopmentActivities/MergeOCN/Vuichard
v37 v38 21 21 == SOM decomposition - Routine : som_dynamics == 22 22 23 *'''fraction from passive to slow pool'''. OCN contains the version of Century published in 1993 while the ORCHIDEE is more based on the publication of 1987. The fraction towards the passive pool of the carbon flow that goes out of the slow pool is set to 0.03 in Parton 1987, instead of 0.003-0.009*clay_fraction in Parton, 1993. Soenke kept the parametrization of 1987. There is no clear motivation on the reason why.23 1. '''fraction from passive to slow pool'''. OCN contains the version of Century published in 1993 while the ORCHIDEE is more based on the publication of 1987. The fraction towards the passive pool of the carbon flow that goes out of the slow pool is set to 0.03 in Parton 1987, instead of 0.003-0.009*clay_fraction in Parton, 1993. Soenke kept the parametrization of 1987. There is no clear motivation on the reason why. 24 24 25 25 == N flows in soil - Routine : nitrogen_dynamics == 26 26 27 *'''Calculation of the anaerobic balloon'''. Nitrification and denitrification are varying (oppositely) depending of the anaerobic condition in soils as done in Li et al., 2000. This is done by using a variable named anvf (for ANaerobic Volumetric Fraction). In Li et al. (2000), anvf is calculated using the oxygen diffusion coefficient (Ds) which makes use of the air-filled porosity (afps). In OCN, the calculation of afps is defined with the following equation but not used later in the calculation of Ds. (See, [source:branches/orchidee-N/ORCHIDEE/src_stomate/stomate_soilcarbon.f90@19#L665 here])27 1. '''Calculation of the anaerobic balloon'''. Nitrification and denitrification are varying (oppositely) depending of the anaerobic condition in soils as done in Li et al., 2000. This is done by using a variable named anvf (for ANaerobic Volumetric Fraction). In Li et al. (2000), anvf is calculated using the oxygen diffusion coefficient (Ds) which makes use of the air-filled porosity (afps). In OCN, the calculation of afps is defined with the following equation but not used later in the calculation of Ds. (See, [source:branches/orchidee-N/ORCHIDEE/src_stomate/stomate_soilcarbon.f90@19#L665 here]) 28 28 {{{ 29 29 d_ox(:) = 1.73664 * ( 0.15 * (exp(-(soilhum_av(:)**3.)/0.44)-exp(-1./0.44))) * & … … 34 34 We keep here the original formulation of Li et al., 2000 35 35 36 *'''Calculation of the oxygen partial pressure'''. For both the calculation of the gradient of oxygen partial pressure (d(pO2)/dz) and the change in oxygen partial pressure (d(pO2)/dt), we need dz, the depth over which one makes the calculation. It is not clear to me which depth one should use. For information, OCN used z_decomp (see [source:branches/orchidee-N/ORCHIDEE/src_stomate/stomate_soilcarbon.f90@19#L705 here])36 2. '''Calculation of the oxygen partial pressure'''. For both the calculation of the gradient of oxygen partial pressure (d(pO2)/dz) and the change in oxygen partial pressure (d(pO2)/dt), we need dz, the depth over which one makes the calculation. It is not clear to me which depth one should use. For information, OCN used z_decomp (see [source:branches/orchidee-N/ORCHIDEE/src_stomate/stomate_soilcarbon.f90@19#L705 here]) 37 37 38 *'''Calculation of the oxygen partial pressure''' (2). Still in the calculation of the change in oxygen partial pressure (d(pO2)/dt) in OCN, it seems that "dz" term (z_decomp) is missing in the following equation (see [source:branches/orchidee-N/ORCHIDEE/src_stomate/stomate_soilcarbon.f90@19#L705 here]) when we compare with the reference formulation (Li et al., 2000, Eq. 4 of Table 2)38 3. '''Calculation of the oxygen partial pressure''' (2). Still in the calculation of the change in oxygen partial pressure (d(pO2)/dt) in OCN, it seems that "dz" term (z_decomp) is missing in the following equation (see [source:branches/orchidee-N/ORCHIDEE/src_stomate/stomate_soilcarbon.f90@19#L705 here]) when we compare with the reference formulation (Li et al., 2000, Eq. 4 of Table 2) 39 39 40 *'''Conversion Respiration to O2 pressure'''. The conversion factor [source:branches/orchidee-N/ORCHIDEE/src_stomate/stomate_soilcarbon.f90@19#L699 here] used for converting the respiration term in O2 pressure accounts for the air-filled porosity (see Li et al., 2000 eq. 3 table 2). In OCN, afps_max is used instead of afps. We keep the original formulation40 4. '''Conversion Respiration to O2 pressure'''. The conversion factor [source:branches/orchidee-N/ORCHIDEE/src_stomate/stomate_soilcarbon.f90@19#L699 here] used for converting the respiration term in O2 pressure accounts for the air-filled porosity (see Li et al., 2000 eq. 3 table 2). In OCN, afps_max is used instead of afps. We keep the original formulation 41 41 42 *'''Calculation of the anaerobic balloon - anvf'''. The two constants a and b are not specified in Li et al., 2000. OCN uses a=0.85 and b=1 without mention to any publication (see [source:branches/orchidee-N/ORCHIDEE/src_stomate/stomate_soilcarbon.f90@19#L711 here]). As mention in the code of OCN these parameters have been estimated temporarily and need to be tuned. Might be good to find the values used in DNDC...42 5. '''Calculation of the anaerobic balloon - anvf'''. The two constants a and b are not specified in Li et al., 2000. OCN uses a=0.85 and b=1 without mention to any publication (see [source:branches/orchidee-N/ORCHIDEE/src_stomate/stomate_soilcarbon.f90@19#L711 here]). As mention in the code of OCN these parameters have been estimated temporarily and need to be tuned. Might be good to find the values used in DNDC... 43 43 44 *'''Ammonium adsorption'''. It is based on Li et al. 1992, JGR, Table 4 using NH4 defined as the NH4+ concentration in the soil liquid, gN kg-1 soil (p. 9774) but Zhang et al. (2000) use also the same equation but in this paper NH4+ is defined as the [NH4+] in a soil layer in kgN ha-1. In OCN, NH4 seems defined as molNH4 m-3 of water (see, [source:branches/orchidee-N/ORCHIDEE/src_stomate/stomate_soilcarbon.f90@19#L742 here]). It would be good to clarify this by checking what looks like the equation depending of the units we use.44 6. '''Ammonium adsorption'''. It is based on Li et al. 1992, JGR, Table 4 using NH4 defined as the NH4+ concentration in the soil liquid, gN kg-1 soil (p. 9774) but Zhang et al. (2000) use also the same equation but in this paper NH4+ is defined as the [NH4+] in a soil layer in kgN ha-1. In OCN, NH4 seems defined as molNH4 m-3 of water (see, [source:branches/orchidee-N/ORCHIDEE/src_stomate/stomate_soilcarbon.f90@19#L742 here]). It would be good to clarify this by checking what looks like the equation depending of the units we use. 45 45 46 *'''Ammonium adsorption''' (2). Li et al. (1992) defines FIXNH4 as the proportion of adsorbed NH4+. One may assume that consequently the NH4+ that is not adsorbed is NH4+ x (1-FIXNH4) and that we want to consider this quantity for possible nitrification, transformation to ammonia, .... But in OCN, we do not multiply the state variable (SV) representing NH4+ by (1-FixNH4) but by (1-FixNH4/(1+FixNH4)) (see, [source:branches/orchidee-N/ORCHIDEE/src_stomate/stomate_soilcarbon.f90@19#L746 here]). This tends to assume that FixNH4 represents the ratio adsorped NH4+ to non-adsorped because FixNH4/(1+FixNH4) = (NH4adsorp/NH4non_adsorp)/((NH4non_adsorp+NH4adsorp)/NH4_non_adsorp) = NH4adsorp / NH4tot. This needs to be clarified ...46 7. '''Ammonium adsorption''' (2). Li et al. (1992) defines FIXNH4 as the proportion of adsorbed NH4+. One may assume that consequently the NH4+ that is not adsorbed is NH4+ x (1-FIXNH4) and that we want to consider this quantity for possible nitrification, transformation to ammonia, .... But in OCN, we do not multiply the state variable (SV) representing NH4+ by (1-FixNH4) but by (1-FixNH4/(1+FixNH4)) (see, [source:branches/orchidee-N/ORCHIDEE/src_stomate/stomate_soilcarbon.f90@19#L746 here]). This tends to assume that FixNH4 represents the ratio adsorped NH4+ to non-adsorped because FixNH4/(1+FixNH4) = (NH4adsorp/NH4non_adsorp)/((NH4non_adsorp+NH4adsorp)/NH4_non_adsorp) = NH4adsorp / NH4tot. This needs to be clarified ... 47 47 48 *'''Nitrification rate'''. The equation for the nitrification rate comes from Schmid et al., 2001, Nutr. Cycl. Agro (eq.1) but the environmental factors used are from Zhang (2002) who used an other equation, especially for Temperature effect on nitrification. I don't know how this can be mixed together ? This seems particularly inappropriate because the default fraction of N-NH4 which is converted to N-NO3 appears equal to 2 day-1 (a factor "2" in the equation, see [source:branches/orchidee-N/ORCHIDEE/src_stomate/stomate_soilcarbon.f90@19#L805 here]). In Schmid et al., the nitrification rate at 20 ◦C and field capacity (knitrif,20) was set to 0.2 d−1 (10 times less...)48 8. '''Nitrification rate'''. The equation for the nitrification rate comes from Schmid et al., 2001, Nutr. Cycl. Agro (eq.1) but the environmental factors used are from Zhang (2002) who used an other equation, especially for Temperature effect on nitrification. I don't know how this can be mixed together ? This seems particularly inappropriate because the default fraction of N-NH4 which is converted to N-NO3 appears equal to 2 day-1 (a factor "2" in the equation, see [source:branches/orchidee-N/ORCHIDEE/src_stomate/stomate_soilcarbon.f90@19#L805 here]). In Schmid et al., the nitrification rate at 20 ◦C and field capacity (knitrif,20) was set to 0.2 d−1 (10 times less...) 49 49 50 *'''NO production from chemodenitrification'''. This is based on Kesik et al., 2005, Biogeosciences but Kesik et al. used NO2 concentration and not NO3 production as it is done in OCN. In parallel, there is a modification of a multiplicative constant from 300 (Kesik) to 30 (OCN). See the line in the code of OCN [source:branches/orchidee-N/ORCHIDEE/src_stomate/stomate_soilcarbon.f90@19#L809 here]. I don't know how this is reliable ?50 9. '''NO production from chemodenitrification'''. This is based on Kesik et al., 2005, Biogeosciences but Kesik et al. used NO2 concentration and not NO3 production as it is done in OCN. In parallel, there is a modification of a multiplicative constant from 300 (Kesik) to 30 (OCN). See the line in the code of OCN [source:branches/orchidee-N/ORCHIDEE/src_stomate/stomate_soilcarbon.f90@19#L809 here]. I don't know how this is reliable ? 51 51 52 *'''NO production and N2O production'''. In OCN, NO production and N2O production are deduced from the NO3 production based on the calculation of the nitrification rate (see above). See [el, there is a modification of a multiplicative constant from 300 (Kesik) to 30 (OCN). See the line in the code of OCN [source:branches/orchidee-N/ORCHIDEE/src_stomate/stomate_soilcarbon.f90@19#L812 here]. I don't know if this is correct ?52 10. '''NO production and N2O production'''. In OCN, NO production and N2O production are deduced from the NO3 production based on the calculation of the nitrification rate (see above). See [el, there is a modification of a multiplicative constant from 300 (Kesik) to 30 (OCN). See the line in the code of OCN [source:branches/orchidee-N/ORCHIDEE/src_stomate/stomate_soilcarbon.f90@19#L812 here]. I don't know if this is correct ? 53 53 54 *'''Relative growth rate of Nox denitrifiers'''. One uses a parameter defined as the Half Saturation of N oxydes (kgN/m3) from Table 4 of Li et al., 2000. It is set to 0.083 in Li et al. and OCN uses the value 0.087. We keep the original value. It is also not clear if the unit of this parameter are kgN per m3 of soil or per m3 of solution. In OCN, when converting from (kgN m-3) to (gN m-2) we multiply by "dpu_cste*mx_eau_eau" (see [source:branches/orchidee-N/ORCHIDEE/src_stomate/stomate_soilcarbon.f90@19#L832 here]. I don't know if this is correct. If it is per m3 of solution one should at least consider that soil is not necessary at the field capacity (ie. dpu_cste*mx_eau_eau*soilhum).54 11. '''Relative growth rate of Nox denitrifiers'''. One uses a parameter defined as the Half Saturation of N oxydes (kgN/m3) from Table 4 of Li et al., 2000. It is set to 0.083 in Li et al. and OCN uses the value 0.087. We keep the original value. It is also not clear if the unit of this parameter are kgN per m3 of soil or per m3 of solution. In OCN, when converting from (kgN m-3) to (gN m-2) we multiply by "dpu_cste*mx_eau_eau" (see [source:branches/orchidee-N/ORCHIDEE/src_stomate/stomate_soilcarbon.f90@19#L832 here]. I don't know if this is correct. If it is per m3 of solution one should at least consider that soil is not necessary at the field capacity (ie. dpu_cste*mx_eau_eau*soilhum). 55 55 56 *'''Relative growth rate of Nox denitrifiers (2)'''. In OCN, the term mu_nox(max) is missing in the equation that defines the relative growth rate of total denitrifiers (see eq. 2 of Table 4 of Li et al., 2000). See [source:branches/orchidee-N/ORCHIDEE/src_stomate/stomate_soilcarbon.f90@19#L845 here]. In addition, in OCN, the Relative growth rate of Nox denitrifiers is ranged between 0.0005*som(:,iactive,m,icarbon) and 0.25 * som(:,iactive,m,icarbon)). No clear justification. This is not kept so far.56 12. '''Relative growth rate of Nox denitrifiers (2)'''. In OCN, the term mu_nox(max) is missing in the equation that defines the relative growth rate of total denitrifiers (see eq. 2 of Table 4 of Li et al., 2000). See [source:branches/orchidee-N/ORCHIDEE/src_stomate/stomate_soilcarbon.f90@19#L845 here]. In addition, in OCN, the Relative growth rate of Nox denitrifiers is ranged between 0.0005*som(:,iactive,m,icarbon) and 0.25 * som(:,iactive,m,icarbon)). No clear justification. This is not kept so far. 57 57 58 *'''NO3 consumption by denitrification'''. This is based on Eq. 4 Table 4 of Li et al., 2000. In OCN ([source:branches/orchidee-N/ORCHIDEE/src_stomate/stomate_soilcarbon.f90@19#L848 here]), multiplication by 0.1 of the NO3 consumption. There is no justification. This is not kept so far.58 13. '''NO3 consumption by denitrification'''. This is based on Eq. 4 Table 4 of Li et al., 2000. In OCN ([source:branches/orchidee-N/ORCHIDEE/src_stomate/stomate_soilcarbon.f90@19#L848 here]), multiplication by 0.1 of the NO3 consumption. There is no justification. This is not kept so far. 59 59 60 *'''denitrifier bacterial population change'''. This is based on Eq. 3 of Table 4 Li et al. (2000). In OCN, there is only the denitrifier bact population change that is defined, not the population itself. And the bacterial population change is used in place of the bacterial population in the calculation of the production of NO3, NOx, N2O by denitrification. [source:branches/orchidee-N/ORCHIDEE/src_stomate/stomate_soilcarbon.f90@19#L845 here]. I don't know how it may work.60 14. '''denitrifier bacterial population change'''. This is based on Eq. 3 of Table 4 Li et al. (2000). In OCN, there is only the denitrifier bact population change that is defined, not the population itself. And the bacterial population change is used in place of the bacterial population in the calculation of the production of NO3, NOx, N2O by denitrification. [source:branches/orchidee-N/ORCHIDEE/src_stomate/stomate_soilcarbon.f90@19#L845 here]. I don't know how it may work. 61 61 62 *'''Vmax of nitrogen uptake by plants'''. In OCN, the same values are used both for uptake of NH4+ and NO3-. See p. 3 of the SM of Zaehle & Friend, 2010: "''As a first approximation average values for vmax, kNmin and KNmin are assumed for all PFTs (Table S1), and for both ammonium and nitrate''". However based on the two papers of Kronzucker et al. (1995, 1996), it seems that vmax should be much higher for NH4+ than for NO3- . We still use the same here for both NH4+ and NO3- as in OCN.62 15. '''Vmax of nitrogen uptake by plants'''. In OCN, the same values are used both for uptake of NH4+ and NO3-. See p. 3 of the SM of Zaehle & Friend, 2010: "''As a first approximation average values for vmax, kNmin and KNmin are assumed for all PFTs (Table S1), and for both ammonium and nitrate''". However based on the two papers of Kronzucker et al. (1995, 1996), it seems that vmax should be much higher for NH4+ than for NO3- . We still use the same here for both NH4+ and NO3- as in OCN. 63 63 64 *'''Vmax of nitrogen uptake by plants''' (2). I can not relate the value of vmax in OCN expressed in (umol (g DryWeight_root)-1 h-1) (vmax=3 [source:branches/orchidee-N/ORCHIDEE/src_stomate/stomate_soilcarbon.f90@19#L595 here]) to the one reported in Table S1 of Zaehle & Friend, 2010 (vmax=5.14 ugN (g-1C) d-1). The use of the conv_fac conversion factor used in OCN ([source:branches/orchidee-N/ORCHIDEE/src_stomate/stomate_soilcarbon.f90@19#L869 here]) should help to convert (umol (g dryWeight_root)-1 h-1) in (gN (g-1C) tstep-1). conv_fac is defined as 24. * dt / 2. / 1000000. * 14 with:64 16. '''Vmax of nitrogen uptake by plants''' (2). I can not relate the value of vmax in OCN expressed in (umol (g DryWeight_root)-1 h-1) (vmax=3 [source:branches/orchidee-N/ORCHIDEE/src_stomate/stomate_soilcarbon.f90@19#L595 here]) to the one reported in Table S1 of Zaehle & Friend, 2010 (vmax=5.14 ugN (g-1C) d-1). The use of the conv_fac conversion factor used in OCN ([source:branches/orchidee-N/ORCHIDEE/src_stomate/stomate_soilcarbon.f90@19#L869 here]) should help to convert (umol (g dryWeight_root)-1 h-1) in (gN (g-1C) tstep-1). conv_fac is defined as 24. * dt / 2. / 1000000. * 14 with: 65 65 - 24 conversion of hour to day 66 66 - dt conversion of day to dt … … 70 70 So using conv_fac, vmax expressed in ugN (g-1C) d-1 should be equal to 3*24./2.*14. = 504 ugN (gC)-1 d-1 not 5.14 71 71 72 *'''Vmax of nitrogen uptake by plants''' (3). I think there is an error in the conversion factor conv_fac ([source:branches/orchidee-N/ORCHIDEE/src_stomate/stomate_soilcarbon.f90@19#L869 here]) from (gDW)-1 to (gC)-1. When expressed per gC of root, the N uptake should be twice more than the one expressed per gDW of root, not twice less. So one should multiply by 2., not divide by 2. And so vmax should be equal to 2016 ug (gC)-1 d-1 (not 504).72 17. '''Vmax of nitrogen uptake by plants''' (3). I think there is an error in the conversion factor conv_fac ([source:branches/orchidee-N/ORCHIDEE/src_stomate/stomate_soilcarbon.f90@19#L869 here]) from (gDW)-1 to (gC)-1. When expressed per gC of root, the N uptake should be twice more than the one expressed per gDW of root, not twice less. So one should multiply by 2., not divide by 2. And so vmax should be equal to 2016 ug (gC)-1 d-1 (not 504). 73 73 74 *'''N uptake by plants'''. See eq. (8) p. 3 of SM of Zaehle & Friend, 2010. In OCN, there was a multiplicative factor "2" that I can not explain (see [source:branches/orchidee-N/ORCHIDEE/src_stomate/stomate_soilcarbon.f90@19#L897 here]). It may partly compensate (half compensation) the error mentioned above about conv_fac.74 18. '''N uptake by plants'''. See eq. (8) p. 3 of SM of Zaehle & Friend, 2010. In OCN, there was a multiplicative factor "2" that I can not explain (see [source:branches/orchidee-N/ORCHIDEE/src_stomate/stomate_soilcarbon.f90@19#L897 here]). It may partly compensate (half compensation) the error mentioned above about conv_fac. 75 75 76 *'''Coefficient K_N_min'''. It corresponds to the [NH4+] (resp. [NO3-]) for which the Nuptake equals vmax/2. Kronzucker, 1995 reports values that range between 20 and 40 umol for NH4+ uptake. OCN seems to use 30 umol for both NH4+ and NO3-, because the value used in the code of OCN expressed in (gN m-2) is 0.84 (see [source:branches/orchidee-N/ORCHIDEE/src_stomate/stomate_soilcarbon.f90@19#L897 here]). In addition, in Kronzucker, 1995 and 1996, the concentrations are always expressed in umol. There is no clear reference about the standard volume it is related to. I assumed it is litter.76 19. '''Coefficient K_N_min'''. It corresponds to the [NH4+] (resp. [NO3-]) for which the Nuptake equals vmax/2. Kronzucker, 1995 reports values that range between 20 and 40 umol for NH4+ uptake. OCN seems to use 30 umol for both NH4+ and NO3-, because the value used in the code of OCN expressed in (gN m-2) is 0.84 (see [source:branches/orchidee-N/ORCHIDEE/src_stomate/stomate_soilcarbon.f90@19#L897 here]). In addition, in Kronzucker, 1995 and 1996, the concentrations are always expressed in umol. There is no clear reference about the standard volume it is related to. I assumed it is litter. 77 77 78 *'''Conversion factor from (umol per litter) to (gN m-2) for K_N_min'''. I assumed conv_fac_concent equals to 14 * 1e3 * 1e-6 * 2 with78 20. '''Conversion factor from (umol per litter) to (gN m-2) for K_N_min'''. I assumed conv_fac_concent equals to 14 * 1e3 * 1e-6 * 2 with 79 79 - 14 : molar mass for N (gN mol-1) 80 80 - 10^3^ : conversion factor (dm3 to m3) … … 83 83 I wonder why it assumes 2 m3 per m2 of soil. The depth of the soil is 2 meter but it doesn't mean that all the column contains only water, there is also soil, no ? The question is : what is the volume that is considered for the concentration of NH4+ and NO3-. Is it a volume of soil or of solution ? If it is a volume of solution, I would suggest to multiply by a factor corresponding to the relative volume of water within the soil (like soilhum). Not done yet. 84 84 85 *'''Coefficient low_K_N_min'''. See eq. 8 of SM of Zaehle et al. (2010) and Table S1. In table S1, it is defined as the "Rate of N uptake not associated with Michaelis- Menten Kinetics" and the given value is 0.05 (-). It is mentioned also (unitless) but to my opinion it should have the same unit that 1/K_N_min or 1/N_min, so ((gN m-2)-1). So far, I cannot relate the value of low_K_N_min (0.05) to any reference, especially Kronzucker (1996). If I refer to Figure 4 of Kronzucker showing the NH4+ influx as a function of NH4+ concentration, the slope of the relationship could be used to define Vmax*low_K_N_min.85 21. '''Coefficient low_K_N_min'''. See eq. 8 of SM of Zaehle et al. (2010) and Table S1. In table S1, it is defined as the "Rate of N uptake not associated with Michaelis- Menten Kinetics" and the given value is 0.05 (-). It is mentioned also (unitless) but to my opinion it should have the same unit that 1/K_N_min or 1/N_min, so ((gN m-2)-1). So far, I cannot relate the value of low_K_N_min (0.05) to any reference, especially Kronzucker (1996). If I refer to Figure 4 of Kronzucker showing the NH4+ influx as a function of NH4+ concentration, the slope of the relationship could be used to define Vmax*low_K_N_min. 86 86 * For a concentration of NH4+ of 50 mmol, the influx equals 35 umol g-1 h-1. 87 87 * For a concentration of NH4+ of 20 mmol, the influx equals 17 umol g-1 h-1. So the slope can be written as … … 94 94 The value of 0.007 does not match with the one in OCN (0.05, (see [source:branches/orchidee-N/ORCHIDEE/src_stomate/stomate_soilcarbon.f90@19#L897 here])). This needs to be clarified 95 95 96 *'''N uptake by plants''' (2). In eq. 8 of SM of Zaehle et al. (2010) I think there is an error. It should not be (Nmin X KNmin) but (Nmin + KNmin). The source code of OCN is correct (see [source:branches/orchidee-N/ORCHIDEE/src_stomate/stomate_soilcarbon.f90@19#L897 here]).96 22. '''N uptake by plants''' (2). In eq. 8 of SM of Zaehle et al. (2010) I think there is an error. It should not be (Nmin X KNmin) but (Nmin + KNmin). The source code of OCN is correct (see [source:branches/orchidee-N/ORCHIDEE/src_stomate/stomate_soilcarbon.f90@19#L897 here]). 97 97 98 *'''Loss of NH4 due to volatilisation of NH3'''. See Li et al. 1992, JGR, Table 4. It's used the current dissociation of [NH3] to [NH4+] (see Table 4 and Appendix A of Zhang et al. 2002):98 23. '''Loss of NH4 due to volatilisation of NH3'''. See Li et al. 1992, JGR, Table 4. It's used the current dissociation of [NH3] to [NH4+] (see Table 4 and Appendix A of Zhang et al. 2002): 99 99 {{{ 100 100 log(K_NH4) - log(K_H20) = log(NH4/NH3) + pH … … 112 112 }}} 113 113 I have several interrogations about the equation and value used in OCN. But I have also concerns about the formulation of Li et al. ... 114 1. The formulation of Li et al. doesn't match with the formulas in "DISSOCIATION CONSTANTS OF INORGANIC ACIDS AND BASES" ([http://sites.chem.colostate.edu/diverdi/all_courses/CRC%20reference%20data/dissociation%20constants%20of%20inorganic%20acids%20and%20bases.pdf here]) or with the formulas of http://www.onlinebiochemistry.com/obj-512/Chap4-StudNotes.html. To my opinion, one should replace log(K_NH4+) by log(K_NH3) in the formulation of Li et al. With the relationship pKa + pKb = pKwater (where a and b are acid and base) this leads to [NH4+]/[NH3] = 10^(pK_NH4 - pH)^ = 10^(9.25 - pH)115 2. Wether I'm right or not about 1., I don't understand the value used in OCN (4.25). It should be either 4.75 or 9.25 but 4.25 looks strange116 3. OCN used a formulation for [NH3]/[NH4+] of the type: X/(1+X) with X=[NH3]/[NH4+].114 a. The formulation of Li et al. doesn't match with the formulas in "DISSOCIATION CONSTANTS OF INORGANIC ACIDS AND BASES" ([http://sites.chem.colostate.edu/diverdi/all_courses/CRC%20reference%20data/dissociation%20constants%20of%20inorganic%20acids%20and%20bases.pdf here]) or with the formulas of http://www.onlinebiochemistry.com/obj-512/Chap4-StudNotes.html. To my opinion, one should replace log(K_NH4+) by log(K_NH3) in the formulation of Li et al. With the relationship pKa + pKb = pKwater (where a and b are acid and base) this leads to [NH4+]/[NH3] = 10^(pK_NH4 - pH)^ = 10^(9.25 - pH) 115 b. Wether I'm right or not about a., I don't understand the value used in OCN (4.25). It should be either 4.75 or 9.25 but 4.25 looks strange 116 c. OCN used a formulation for [NH3]/[NH4+] of the type: X/(1+X) with X=[NH3]/[NH4+]. 117 117 This leads to 118 118 X/(1+X)=([NH3]/[NH4+])/(([NH4+]/[NH4+])+([NH3]/[NH4+])) 119 119 or X/(1+X) = [NH3] / ( [NH3] + [NH4+] ) 120 120 This means that the value stored in soil_n_min(:,:,iammonium) corresponds to the total N of both [NH4+] and [NH3]. This makes sense to my opinion, but I wonder if one should not account for this partitioning between [NH4+] and [NH3] in other processes. To check. 121 4. The X value should relate to [NH3]/[NH4+] but to my opinion the X value used in the equation in OCN corresponds to [NH4+]/[NH3]. Is this a bug ?121 d. The X value should relate to [NH3]/[NH4+] but to my opinion the X value used in the equation in OCN corresponds to [NH4+]/[NH3]. Is this a bug ? 122 122 In conclusion, I propose the formulation 123 123 {{{ … … 125 125 }}} 126 126 127 *'''Reduction of the ammonia volatilization'''. See [source:branches/orchidee-N/ORCHIDEE/src_stomate/stomate_soilcarbon.f90@19#L953 here]. This seems a patch added to OCN in order to (as mentioned in OCN) reduced emissions at low concentration (problem of only one soil layer). This is not activated yet but it is kept as a comment.127 24. '''Reduction of the ammonia volatilization'''. See [source:branches/orchidee-N/ORCHIDEE/src_stomate/stomate_soilcarbon.f90@19#L953 here]. This seems a patch added to OCN in order to (as mentioned in OCN) reduced emissions at low concentration (problem of only one soil layer). This is not activated yet but it is kept as a comment. 128 128 129 *'''Emission of geseous species'''. In OCN ([source:branches/orchidee-N/ORCHIDEE/src_stomate/stomate_soilcarbon.f90@19#L977 here] for instance), one used formulations of the type129 25. '''Emission of geseous species'''. In OCN ([source:branches/orchidee-N/ORCHIDEE/src_stomate/stomate_soilcarbon.f90@19#L977 here] for instance), one used formulations of the type 130 130 {{{ 131 131 emission = d_ox(:) * soil_n_min(:,m,inox) * (0.13-0.079*clay(:)) * dt / z_decomp … … 136 136 137 137 138 *'''Update pools of nitrogen in the soil'''. See [source:branches/orchidee-N/ORCHIDEE/src_stomate/stomate_soilcarbon.f90@19#L995 here]. To my opinion, for a better consistency, I would recommand to consider the leaching separately when calculating the ammonium and nitrate budget. Leaching is calculated from sechiba. It might be better to remove leaching at the top of the routine especially due to the later calculation of NH4+ and NO3- concentration that will vary with the soil water content. Let's imagine that from one time step to another, the change in soil water content is only due to leaching. We don't want that the NH4+ and NO3- concentration vary from one time step to the other. The best way to avoid this is to remove first the leaching from the NH4+ and NO3- pools. This is not done yet.138 26. '''Update pools of nitrogen in the soil'''. See [source:branches/orchidee-N/ORCHIDEE/src_stomate/stomate_soilcarbon.f90@19#L995 here]. To my opinion, for a better consistency, I would recommand to consider the leaching separately when calculating the ammonium and nitrate budget. Leaching is calculated from sechiba. It might be better to remove leaching at the top of the routine especially due to the later calculation of NH4+ and NO3- concentration that will vary with the soil water content. Let's imagine that from one time step to another, the change in soil water content is only due to leaching. We don't want that the NH4+ and NO3- concentration vary from one time step to the other. The best way to avoid this is to remove first the leaching from the NH4+ and NO3- pools. This is not done yet. 139 139 140 *'''Additional general comments'''. From my reading of the code of OCN, it appears that there are at least 3 processes/calculations for which we really need to be careful:140 27. '''Additional general comments'''. From my reading of the code of OCN, it appears that there are at least 3 processes/calculations for which we really need to be careful: 141 141 1. The use of the anaerobic balloon. We need to check if the fraction ''anvf'' is used in the relevant equations or not. 142 142 2. The use of reference depth especially for the calculation of the different emissions. Is z_decomp the most appropriate reference depth ? How this depth should be related to the depth of the soil we consider in the N-related processes (and the parameter dpu_cste ?
