Changes between Version 34 and Version 35 of DevelopmentActivities/MergeOCN/Vuichard

Timestamp:

2014-02-06T16:50:14+01:00 (10 years ago)

Author:

nvuilsce

Comment:

--

DevelopmentActivities/MergeOCN/Vuichard

@@ -129 +129 @@
 emission = d_ox(:) * soil_n_min(:,m,inox) * (0.13-0.079*clay(:)) * dt / z_decomp
 }}}
- It should have the units of d_ox * soil_n_min * dt / z_decomp
-                 or so,  m2 day-1 * gN m-2     * day/ m = gN / m which is not homogeneous with the unit expected (gN m-2)
+ It should have the units of ''d_ox'' * ''soil_n_min'' * ''dt'' / ''z_decomp''
+                 or so,  ''m2 day-1'' * ''gN m-2'' * ''day'' / ''m'' = gN / m which is not homogeneous with the unit expected (gN m-2)
  To my opinion, one should not use soil_n_min (gN m-2) but a volumetric concentration (gN m-3), but I'm not clear what is the appropriate volume to consider (volume of soil, air-filled porosity, ...)
 
 
+ * '''Update pools of nitrogen in the soil'''. See [source:branches/orchidee-N/ORCHIDEE/src_stomate/stomate_soilcarbon.f90@19#L995 here]. To my opinion, for a better consistency, I would recommand to consider the leaching separately when calculating the ammonium and nitrate budget. Leaching is calculated from sechiba. It might be better to remove leaching at the top of the routine especially due to the later calculation of NH4+ and NO3- concentration that will vary with the soil water content. Let's imagine that from one time step to another, the change in soil water content is only due to leaching. We don't want that the NH4+ and NO3- concentration vary from one time step to the other. The best way to avoid this is to remove first the leaching from the NH4+ and NO3- pools. This is not done yet. 
 
+