| 32 | | * '''Calculation of the oxygen partial pressure'''. Still in the calculation of the change in oxygen partial pressure ([source:branches/orchidee-N/ORCHIDEE/src_stomate/stomate_soilcarbon.f90@19#L703, see here]), in OCN it is written as : pO2(t+dt)=pO2(t)+d(pO2)/dt. To my opinion, multiplying by conv the pO2 term at right of = sign is a bug. pO2 at the left and right of the = sign, should have the same unit because the units of pO2 are not modified later in nitrogen_dynamics routine ([source:branches/orchidee-N/ORCHIDEE/src_stomate/stomate_soilcarbon.f90@19#L705, here] and [source:branches/orchidee-N/ORCHIDEE/src_stomate/stomate_soilcarbon.f90@19#L707, here]) nor elsewhere (in stomate or stomate_lpj). |
| | 32 | * '''Calculation of the oxygen partial pressure'''. The conversion factor [source:branches/orchidee-N/ORCHIDEE/src_stomate/stomate_soilcarbon.f90@19#L699, here] used for converting the respiration term in O2 pressure accounts for the air-filled porosity (see Li et al., 2000 eq. 3 table 2). In OCN, afps_max is used instead of afps. We keep the original formulation |
| | 33 | |
| | 34 | * '''Calculation of the anaerobic balloon - anvf'''. The two constants a and b are not specified in Li et al., 2000. OCN uses a=0.85 and b=1 without mention to any publication (see [source:branches/orchidee-N/ORCHIDEE/src_stomate/stomate_soilcarbon.f90@19#L711, here]). As mention in the code of OCN these parameters have been estimated temporarily and need to be tuned. Might be good to find the values used in DNDC... |
