Changes between Version 31 and Version 32 of DevelopmentActivities/Bugs


Ignore:
Timestamp:
2016-03-16T16:54:50+01:00 (8 years ago)
Author:
ajornet
Comment:

--

Legend:

Unmodified
Added
Removed
Modified
  • DevelopmentActivities/Bugs

    v31 v32  
    114114 
    115115Attention: the use of WHERE statement with min_stomate is a bad practice which leads to potential bugs. What if the value is negative? In this case it would be ignored. 
     116 
     117= Merge Issues = 
     118 
     119== Revision 2944 == 
     120 
     121changeset:2944 
     122 
     123There is a conflict at lpj_gap. The conditions in the trunk are slightly different from MICT. The code from MICT is already updated with log's change. Is there any problem? 
     124 
     125{{{ 
     126          IF ( ok_dgvm .AND. (tmin_crit(j) .NE. undef) ) THEN 
     127             ! frost-sensitive PFTs 
     128             WHERE ( t2m_min_daily(:) .LT. tmin_crit(j) ) 
     129                mortality(:,j) = MIN(un,(coldness_mort*(tmin_crit(j)-t2m_min_daily(:))+mortality(:,j) ) ) 
     130             ENDWHERE 
     131          ENDIF 
     132 
     133          IF ( ok_dgvm .AND. leaf_tab(j)==1 .AND. pheno_type(j)==2) THEN 
     134 
     135             ENDWHERE 
     136          ENDIF 
     137 
     138          IF ( ok_dgvm .AND. leaf_tab(j)==1 .AND. pheno_type(j)==2) THEN 
     139<<<<<<< .working 
     140             ! spring frost 
     141             WHERE ( Tmin_spring(:,j) .LT. frost_damage_limit ) 
     142                mortality(:,j) = MIN(un,(0.01*(frost_damage_limit-Tmin_spring(:,j))*Tmin_spring_time(:,j)/spring_days_max+mortality(:,j) ) ) 
     143             ENDWHERE 
     144          ENDIF 
     145======= 
     146             ! Treat the spring frost for broadleaf and summergreen vegetations 
     147             ! leaf_tab=broadleaf and pheno_typ=summergreen 
     148             DO i=1,npts 
     149                IF ( (Tmin_spring_time(i,j)>0) .AND. (Tmin_spring_time(i,j)<spring_days_max+1) ) THEN 
     150                   IF ( t2m_min_daily(i) .LT. frost_damage_limit ) THEN 
     151                      mortality(i,j) = MIN(un,(0.01*(frost_damage_limit-t2m_min_daily(i))* & 
     152                           Tmin_spring_time(i,j)/spring_days_max+mortality(i,j) ) ) 
     153                   END IF 
     154                END IF 
     155             END DO 
     156          END IF 
     157 
     158>>>>>>> .merge-right.r2944 
     159 
     160          !! 1.4 Update biomass and litter pools  
     161          !    Update biomass and litter pool after dying and transfer recently died biomass to litter 
     162}}}