Changeset 2282 for XIOS/dev/dev_ym/XIOS_COUPLING/src/node

Timestamp:

01/07/22 16:09:50 (2 years ago)

Author:

jderouillat

Message:

Add missing return statements detected using -fsanitize=return. Return errors at runtime if reached.

Location:

XIOS/dev/dev_ym/XIOS_COUPLING/src/node

Files:

• axis.hpp (modified) (1 diff)
• domain.hpp (modified) (1 diff)
• grid.cpp (modified) (3 diffs)
• scalar.hpp (modified) (1 diff)

XIOS/dev/dev_ym/XIOS_COUPLING/src/node/axis.hpp

@@ -209 +209 @@
            if (hasDirectAxisReference()) if (!getDirectAxisReference()->isCompleted()) return false;
            else return isCompleted_ ;
+
+           MISSING_RETURN( "bool CAxis::isCompleted() " );
+           return true;
          }
          void setCompleted(void) { isCompleted_=true ; }

XIOS/dev/dev_ym/XIOS_COUPLING/src/node/domain.hpp

@@ -175 +175 @@
            if (hasDirectDomainReference()) if (!getDirectDomainReference()->isCompleted()) return false;
            else return isCompleted_ ;
+
+           MISSING_RETURN( "bool CDomain::isCompleted() " );
+           return true;
          }
          void setCompleted(void) { isCompleted_=true ; }

XIOS/dev/dev_ym/XIOS_COUPLING/src/node/grid.cpp

@@ -461 +461 @@
       }  
     }
+
+    MISSING_RETURN( "CDomain* CGrid::getAssociatedDomain(const string& domainId, bool noError)" );
+    return nullptr;
   } 
 
@@ -525 +528 @@
       }  
     }
+
+    MISSING_RETURN( "CAxis* CGrid::getAssociatedAxis(const string& axisId, bool noError)" );
+    return nullptr;
   } 
 
@@ -589 +595 @@
       }  
     }
+
+    MISSING_RETURN( "CScalar* CGrid::getAssociatedScalar(const string& scalarId, bool noError)" );
+    return nullptr;
   } 
 

XIOS/dev/dev_ym/XIOS_COUPLING/src/node/scalar.hpp

@@ -167 +167 @@
         if (hasDirectScalarReference()) if (!getDirectScalarReference()->isCompleted()) return false;
         else return isCompleted_ ;
+
+        MISSING_RETURN( "bool CAxis::isCompleted() " );
+        return true;
       }
       void setCompleted(void) { isCompleted_=true ; }