Changeset 2265

Timestamp:

11/25/21 18:25:19 (3 years ago)

Author:

ymipsl

Message:

tracking memory leak : remove context and all related object from object factory when context is finalized.
YM

Location:

XIOS/dev/dev_ym/XIOS_COUPLING/src

Files:

• client.cpp (modified) (1 diff)
• interface/c/icdata.cpp (modified) (1 diff)
• manager/server_context.cpp (modified) (1 diff)
• node/calendar_wrapper.hpp (modified) (1 diff)
• node/context.cpp (modified) (1 diff)
• node/context.hpp (modified) (1 diff)
• object_factory.hpp (modified) (1 diff)
• object_factory_decl_macro.hpp (modified) (1 diff)
• object_factory_impl.hpp (modified) (2 diffs)
• object_template.hpp (modified) (2 diffs)
• server.cpp (modified) (1 diff)

XIOS/dev/dev_ym/XIOS_COUPLING/src/client.cpp

@@ -487 +487 @@
       CTimer::get("XIOS init/finalize",false).suspend() ;
       CTimer::get("XIOS").suspend() ;
-      
+      CContext::removeAllContexts() ; // free memory for related context 
       CXios::finalizeDaemonsManager() ;
 

XIOS/dev/dev_ym/XIOS_COUPLING/src/interface/c/icdata.cpp

@@ -135 +135 @@
      CContext* context = CContext::getCurrent();
      context->finalize();
+     CContext::removeContext(context->getId()) ;
      CTimer::get("XIOS context finalize").suspend();
      CTimer::get("XIOS").suspend();

XIOS/dev/dev_ym/XIOS_COUPLING/src/manager/server_context.cpp

@@ -252 +252 @@
       if (context_->eventLoop())
       {
+        info(100)<<"Remove context server with id "<<context_->getId()<<endl ;
+        CContext::removeContext(context_->getId()) ;
         context_=nullptr ;
         // destroy context ??? --> later

XIOS/dev/dev_ym/XIOS_COUPLING/src/node/calendar_wrapper.hpp

@@ -82 +82 @@
   }; // class CCalendarWrapper
 
+  typedef CCalendarWrapper CCalendarWrapperGroup;
   typedef CCalendarWrapper CCalendarWrapperDefinition;
 } // namespace xios

XIOS/dev/dev_ym/XIOS_COUPLING/src/node/context.cpp

@@ -289 +289 @@
    CATCH
 
+void CContext::removeContext(const string& contextId)
+{
+  #define DECLARE_NODE(Name_, name_)     CObjectFactory::deleteContext< C##Name_ >(contextId);
+  #define DECLARE_NODE_PAR(Name_, name_) CObjectFactory::deleteContext< C##Name_ >(contextId);
+  #include "node_type.conf"
+  #define DECLARE_NODE(Name_, name_)     CObjectFactory::deleteContext< C##Name_##Group >(contextId);
+  #define DECLARE_NODE_PAR(Name_, name_) 
+  #include "node_type.conf"
+
+/*
+  #define DECLARE_NODE(Name_, name_)     CObjectFactory::dumpObjects< C##Name_##Group >();
+  #define DECLARE_NODE_PAR(Name_, name_) 
+  #include "node_type.conf"
+
+  #define DECLARE_NODE(Name_, name_)     CObjectFactory::dumpObjects< C##Name_>();
+  #define DECLARE_NODE_PAR(Name_, name_) 
+  #include "node_type.conf"
+*/
+}
+
+void CContext::removeAllContexts(void)
+{
+  #define DECLARE_NODE(Name_, name_)     CObjectFactory::deleteAllContexts< C##Name_ >();
+  #define DECLARE_NODE_PAR(Name_, name_) CObjectFactory::deleteAllContexts< C##Name_ >();
+  #include "node_type.conf"
+  #define DECLARE_NODE(Name_, name_)     CObjectFactory::deleteAllContexts< C##Name_##Group >();
+  #define DECLARE_NODE_PAR(Name_, name_) 
+  #include "node_type.conf"
+/*
+  #define DECLARE_NODE(Name_, name_)     CObjectFactory::dumpObjects< C##Name_##Group >();
+  #define DECLARE_NODE_PAR(Name_, name_) 
+  #include "node_type.conf"
+
+  #define DECLARE_NODE(Name_, name_)     CObjectFactory::dumpObjects< C##Name_>();
+  #define DECLARE_NODE_PAR(Name_, name_) 
+  #include "node_type.conf"
+*/
+}
    ///---------------------------------------------------------------
 

XIOS/dev/dev_ym/XIOS_COUPLING/src/node/context.hpp

@@ -246 +246 @@
         static void ShowTree(StdOStream & out = std::clog);
         static void CleanTree(void);
+        static void removeContext(const std::string& contextId);
+        static void removeAllContexts(void) ;
         int getServiceType(void) {return serviceType_;}
 

XIOS/dev/dev_ym/XIOS_COUPLING/src/object_factory.hpp

@@ -54 +54 @@
              static std::shared_ptr<U> CreateAlias(const StdString& id, const StdString& alias) ;
          
-         template <typename U> static const StdString& GetUIdBase(void);
+         template <typename U> static const StdString GetUIdBase(void);
          template <typename U> static StdString GenUId(void);
          template <typename U> static bool IsGenUId(const StdString& id);
-
+         template <typename U> static void deleteContext(const StdString & context) ;
+         template <typename U> static void deleteAllContexts(void) ;
+         template <typename U> static void dumpObjects(void) ;
       private :
 

XIOS/dev/dev_ym/XIOS_COUPLING/src/object_factory_decl_macro.hpp

@@ -14 +14 @@
   template std::shared_ptr<U> CObjectFactory::CreateObject<U>(const StdString& id ); \
   template std::shared_ptr<U> CObjectFactory::CreateAlias<U>(const StdString& id, const StdString& alias ); \
-  template const StdString& CObjectFactory::GetUIdBase<U>(void); \
+  template const StdString CObjectFactory::GetUIdBase<U>(void); \
   template StdString CObjectFactory::GenUId<U>(void); \
-  template bool CObjectFactory::IsGenUId<U>(const StdString& id);
+  template bool CObjectFactory::IsGenUId<U>(const StdString& id);\
+  template void CObjectFactory::deleteContext<U>(const StdString & context) ;\
+  template void CObjectFactory::deleteAllContexts<U>() ;\
+  template void CObjectFactory::dumpObjects<U>(void) ;
 
 
 
+

XIOS/dev/dev_ym/XIOS_COUPLING/src/object_factory_impl.hpp

@@ -147 +147 @@
 
    template <typename U>
-   const StdString& CObjectFactory::GetUIdBase(void)
-   {
-      static StdString base ; 
+   const StdString CObjectFactory::GetUIdBase(void)
+   {
+      StdString base ; 
 //      base = "__"+CObjectFactory::CurrContext + "::" + U::GetName() + "_undef_id_";
       base = CObjectFactory::CurrContext + "__" + U::GetName() + "_undef_id_";
@@ -166 +166 @@
    bool CObjectFactory::IsGenUId(const StdString& id)
    {
-      const StdString& base = GetUIdBase<U>();
+      const StdString base = GetUIdBase<U>();
       return (id.size() > base.size() && id.compare(0, base.size(), base) == 0);
    }
 
+   template <typename U> 
+   void CObjectFactory::deleteContext(const StdString & context)
+   {
+     for (auto& v : U::AllVectObj[context]) v.reset() ;
+     U::AllVectObj[context].clear() ;
+     U::AllVectObj.erase(context) ; 
+     for (auto& m : U::AllMapObj[context])  m.second.reset() ;
+     U::AllMapObj[context].clear() ;
+     U::AllMapObj.erase(context) ;
+
+     U::GenId.erase(context) ;
+   }
+
+   template <typename U> 
+   void CObjectFactory::deleteAllContexts(void)
+   {
+     list<StdString> contextList ;
+     for(auto& context : U::AllMapObj) contextList.push_back(context.first) ;
+     for(auto& context : contextList) deleteContext<U>(context) ;
+   }
+
+   
+   template <typename U> 
+   void CObjectFactory::dumpObjects(void)
+   {
+     for (auto& context : U::AllMapObj) 
+      for(auto& m : context.second)
+      {
+        info(100)<<"Dump All Object"<<endl ;
+        info(100)<<"Object from context "<<context.first<<" with id "<<m.first<<endl ; 
+      }
+   }
 } // namespace xios
 

XIOS/dev/dev_ym/XIOS_COUPLING/src/object_template.hpp

@@ -124 +124 @@
          CObjectTemplate(void);
          explicit CObjectTemplate(const StdString & id);
-         CObjectTemplate(const CObjectTemplate<T> & object,
-                         bool withAttrList = true, bool withId = true);
+         CObjectTemplate(const CObjectTemplate<T> & object, bool withAttrList = true, bool withId = true);
          CObjectTemplate(const CObjectTemplate<T> * const object); // Not implemented.
 
@@ -131 +130 @@
 
          /// Propriétés statiques ///
-         static xios_map<StdString,
-                xios_map<StdString,
-                std::shared_ptr<DerivedType> > > AllMapObj;
-         static xios_map<StdString,
-                std::vector<std::shared_ptr<DerivedType> > > AllVectObj;
+         static xios_map<StdString, xios_map<StdString, std::shared_ptr<DerivedType> > > AllMapObj;
+         static xios_map<StdString, std::vector<std::shared_ptr<DerivedType> > > AllVectObj;
 
          static xios_map< StdString, long int > GenId ;

XIOS/dev/dev_ym/XIOS_COUPLING/src/server.cpp

@@ -313 +313 @@
 
 //      MPI_Comm_free(&intraComm);
-
+      CContext::removeAllContexts() ; // free memory for related context 
       CXios::finalizeDaemonsManager();