Changeset 47

Timestamp:

07/28/12 10:51:32 (12 years ago)

Author:

dubos

Message:

Fixed sign error in geometry.f90

File:

• codes/icosagcm/trunk/src/geometry.f90 (modified) (3 diffs)

codes/icosagcm/trunk/src/geometry.f90

@@ -343 +343 @@
           ENDDO
 
+          ! Sign convention : Ringler et al., JCP 2010, eq. 21 p. 3071
+          ! Normal component is along outgoing normal vector if ne=1
 
           CALL cross_product2(xyz_v(n+z_rdown,:),xyz_v(n+z_rup,:),vep)
           IF (norm(vep)>1e-30) THEN
-            vep(:)=vep(:)/norm(vep)
-            CALL cross_product2(vep,xyz_e(n+u_right,:),vet)
+            vep(:)=vep(:)/norm(vep)                         ! Inward normal vector
+            CALL cross_product2(vep,xyz_e(n+u_right,:),vet) ! Counter-clockwise tangent vector 
             vet(:)=vet(:)/norm(vet)
-            ep_e(n+u_right,:)=vep(:)*ne(n,right)
+            ep_e(n+u_right,:)=-vep(:)*ne(n,right)
             et_e(n+u_right,:)=vet(:)*ne(n,right)
           ENDIF
@@ -358 +360 @@
             CALL cross_product2(vep,xyz_e(n+u_lup,:),vet)
             vet(:)=vet(:)/norm(vet)
-            ep_e(n+u_lup,:)=vep(:)*ne(n,lup)
+            ep_e(n+u_lup,:)=-vep(:)*ne(n,lup)
             et_e(n+u_lup,:)=vet(:)*ne(n,lup)
           ENDIF
@@ -367 +369 @@
             CALL cross_product2(vep,xyz_e(n+u_ldown,:),vet)
             vet(:)=vet(:)/norm(vet)
-            ep_e(n+u_ldown,:)=vep(:)*ne(n,ldown)
+            ep_e(n+u_ldown,:)=-vep(:)*ne(n,ldown)
             et_e(n+u_ldown,:)=vet(:)*ne(n,ldown)
           ENDIF