Changes between Version 21 and Version 22 of DevelopmentActivities/ORCHIDEE-MICT-IMBALANCE-P/Evaluation
- Timestamp:
- 2015-12-07T10:57:38+01:00 (9 years ago)
Legend:
- Unmodified
- Added
- Removed
- Modified
-
DevelopmentActivities/ORCHIDEE-MICT-IMBALANCE-P/Evaluation
v21 v22 1 = Evaluation = 2 3 == Notes from M. Guimberteau == 4 5 === 2015/08/27 === 6 7 * Bugs 8 9 '''In stomate_wet_ch4_pt_ter_0.f90''' 1 = Solved Issues = 2 3 == Bug report in stomate_wet_ch4_pt_ter_0.f90 by M. Guimberteau on 2015/08/27 == 10 4 11 5 The following parameters need to be defined and this part of the code should be added: … … 23 17 Albert: changed r2906 24 18 25 === 2015/08/24 === 26 27 * Bugs 28 29 '''In thermosoil''' 19 20 == Bug report in thermosoil by M. Guimberteau on 2015/08/24 == 30 21 31 22 The variable SoilTemp should be in the almaoutput condition of the loop and related to ptn_pftmean and not ptn: … … 66 57 Albert: done in r2907. 67 58 68 '''In intersurf and ioipslctrl''' 59 == Bugs report in intersurf and ioipslctrl by M. Guimberteau on 2015/08/24 == 69 60 70 61 The variable ptn_snow_pftmean does not exist in the code anymore. The call histdef should be removed: … … 96 87 97 88 98 ---- 99 100 101 == Notes from F. Maignan == 102 89 == Bug report in thermosoil.f90 / thermosoil_finalize by F. Maignan on 2015/09/10 & 2015/08/31 == 103 90 I've started a 2 degree V6 evaluation at LSCE here:[[BR]] 104 91 /home/surface3/maignan/ORCHIDEE/TESTS/test_MICT_V6/modipsl/modeles/ORCHIDEE/modipsl/config/ORCHIDEE_OL/OOL_SEC_STO_V6[[BR]] 105 92 106 The modified code is in /home/surface3/maignan/ORCHIDEE/TESTS/test_MICT_V6/modipsl 107 108 109 === '''Bugs''' === 110 * '''thermosoil.f90 / thermosoil_finalize''' (2015/09/10 & 2015/08/31) 93 The modified code is in /home/surface3/maignan/ORCHIDEE/TESTS/test_MICT_V6/modipsl[[BR]] 94 111 95 The gthick, gtemp and gpkappa variables were not saved in the restart file.[[BR]] 112 96 The following correction should be applied: … … 145 129 Albert: done in r2909. 146 130 147 * '''stomate.f90 / call writerestart''' (2015/08/27) 131 == Bug report in stomate.f90 / call writerestart by F. Maignan on 2015/08/27 == 148 132 The following correction should be applied: 149 133 {{{ … … 160 144 Albert: done in r2910. 161 145 162 * '''lpj_spitfire.f90 / spitfire''' (2015/08/27) 146 == Bug report in lpj_spitfire.f90 / spitfire by F. Maignan on 2015/08/27 == 163 147 Add: 164 148 {{{ … … 171 155 Albert: done in r2910. 172 156 173 * '''stomate_permafrost_carbon.f90 / snow_interpol / ! 5. inter- or extrapolate''' (2015/08/24)[[BR]] 157 == Bug report in stomate_permafrost_carbon.f90 / snow_interpol / ! 5. inter- or extrapolate by F. Maignan on 2015/08/24 == 174 158 {{{ 175 159 IF ( dzio(ip,iv) .GT. 0. ) THEN … … 183 167 Albert: done in r2910. 184 168 185 * '''stomate_Cforcing_name and stomate_forcing_name''' (2015/08/21) 169 == Bug report in stomate_Cforcing_name and stomate_forcing_name by F. Maignan on 2015/08/21 == 186 170 I've found a problem with the variable Cforcing_name, which is declared both as a global save variable of the stomate module and as a save variable of the stomate_main procedure. It is read in stomate_initialize using a getin_p but indeed the value is not correctly transmitted to the stomate_main procedure. There is also a stomate_Cforcing_name in constantes_var. 187 171 … … 194 178 Albert: done in r2910. 195 179 180 == Bug report on LIGHTNING_FILE by F. Maignan on 2015/08/24 181 LIGHTNING_FILE should not be read if FIRE_DISABLE=y. [[BR]] 182 Albert: done in r2911. 183 196 184 === '''To be corrected''' === 197 * 2015/08/24198 - LIGHTNING_FILE should not be read if FIRE_DISABLE=y. Albert: done in r2911.199 185 * 2015/08/21 200 186 - GRAZING_MAP should not be read if grassland management is not activated. … … 202 188 203 189 204 == Tao==190 == Bug report by T. Wang == 205 191 206 192 There is a small bug in our MICT version that might induce the failure of some point simulations. In subroutine enerbil_flux of enerbil.f90: … … 230 216 Albert: done in r2912. 231 217 232 == Chao==218 == Bug report by C. Yue == 233 219 234 220 Please put these changes in the '''src_stomate/Grassland_Management.f90'''. They're used to protect the division-by-zero from happening. But I don't think this correction is related negative fuel problem. But it could lead to Nan value in fuel if you activate the GM (which is not your case as I checked the run.def you sent before).