Current Bugs

List of bugs that need to be fixed. They are order by priority from the top to the bottom.

Spitfire

There are regative values at fuel_XXhr variables

Suppously, solved at r3021 and r3022. It seems it is not like this.

Multiple floating point exceptions at reat_of_spread

There is a floating overflow exception at exp(XXXX) from lpj_spitfire.f90 -> rate_of_spread

! reaction intensity
a(:)=8.9033*(sigma(:)**(-0.7913))
WHERE (a(:).le.0.00001 .OR. bet(:).le.0.00001)
   dummy(:)=0.0
ELSEWHERE
   dummy(:)=exp(a(:)*(1.0-bet(:)))
ENDWHERE

Proposed solution: set sigma values to 10000. FAILED

     !calculate mass weighted surface-area-to-volume ratio by fuel types.
     WHERE (dead_fuel(:).gt.min_stomate)
       sigma(:)=(fuel_1hr_total(:) * sigma_1hr + &
            fuel_10hr_total(:) * sigma_10hr + &
            fuel_100hr_total(:) * sigma_100hr) / dead_fuel(:)
     ELSEWHERE
       sigma(:)=0.00001 -> 10000
     ENDWHERE

Proposed solution: check sigma instead of a. OK (Accepted by Chao and Fabienne)

! reaction intensity
a(:)=8.9033*(sigma(:)**(-0.7913))
WHERE (sigma(:).le.0.00001 .OR. bet(:).le.0.00001)
   dummy(:)=0.0
ELSEWHERE
   dummy(:)=exp(a(:)*(1.0-bet(:)))
ENDWHERE

PFT maps and Analytic spinup with DGVM

There are no trees with DGVM (without spitfire)

You have a list in pft_parameters:

      !! 5.1 Read the name of the PFTs given by the user
      !
      !Config Key   = PFT_NAME
      !Config Desc  = Name of a PFT
      !Config if    = OK_SECHIBA or OK_STOMATE
      !Config Def   = bare ground, tropical broad-leaved evergreen, tropical broad-leaved raingreen,
      !Config         temperate needleleaf evergreen, temperate broad-leaved evergreen temperate broad-leaved summergreen,
      !Config         boreal needleleaf evergreen, boreal broad-leaved summergreen, boreal needleleaf summergreen,
      !Config         C3 grass, C4 grass, C3 agriculture, C4 agriculture
      !Config Help  = the user can name the new PFTs he/she introducing for new species
      !Config Units = [-]
      CALL getin_p('PFT_NAME',pft_name)

I'm looking at DGVM without SPITFIRE. In dynamic mode, we have first crops but natural PFTs appear later: grasses and after a few years trees. At least that's how it behaves with the TRUNK version.

VSD merge

How to deal with already designed MICT soil layers ?

Hi Shushi,

I made a mystake last Monday because the new vertical discretization had not yet been integrated in Albert's personal branch. Albert is now working on it and we have a few questions.

In Albert's branch, we have two possible different sets of values for soil_capa and soil_cond based on the keyword SOIL_LAYERS_DISCRE_METHOD (see constantes_soil.f90 and get_discretization_constants in thermosoil.f90).

This gives access to two different vertical discretization shemes (see thermosoil_levels). I copied all this relevant code below.

1. Do we agree that we completely let down these two discretization schemes to get the new one (see vertical_soil_init)?

2. I have the impression that soil_capa and soil_cond may intervene elsewhere, do we still keep the two different sets of values?

New Drivers

Test performance