Changes between Version 24 and Version 25 of DevelopmentActivities/Bugs

Timestamp:

2015-12-14T08:52:18+01:00 (9 years ago)

Author:

ajornet

Comment:

--

DevelopmentActivities/Bugs

@@ -9 +9 @@
 Supposedly solved at r3021 and r3022. It seems that it is not the case.
 
-Update: negative values at diff_frac. 
+There are negative values at diff_frac in stomate_litter.
+
+It only fails when DGVM is active.
+
+I disscussed it with Chao, he thinks it comes from somewhere else. I also disscussed with Dan about DGVM. She did not find anything.
+
+It remains to check if this is a problem related only to precission. Due to the use of min_stomate.
+
+
 
 === Multiple floating point exceptions at reat_of_spread ===
@@ -50 +58 @@
 }}}
 
+Attention: the use of WHERE statement with min_stomate is a bad practice which leads to potential bugs. What if the value is negative? In this case it would be ignored.
 
 == River routing ==
@@ -72 +81 @@
 In Albert's branch, we have two possible different sets of values for soil_capa and soil_cond based on the keyword SOIL_LAYERS_DISCRE_METHOD (see constantes_soil.f90 and get_discretization_constants in thermosoil.f90).
 
-This gives access to two different vertical discretization shemes (see thermosoil_levels). I copied all this relevant code below.
+This gives access to two different vertical discretization schemes (see thermosoil_levels). I copied all this relevant code below.
 
 
@@ -79 +88 @@
 2. I have the impression that soil_capa and soil_cond may intervene elsewhere, do we still keep the two different sets of values?
 
+Note: this is a good opportunity to introduce unit tests.
 
 == Forcesoil ==