Changeset 917

Timestamp:

06/18/19 15:53:26 (5 years ago)

Author:

dubos

Message:

devel : DYSL for compute_theta

Location:

codes/icosagcm/devel/src

Files:

• dynamics/caldyn_hevi.f90 (modified) (1 diff)
• dynamics/compute_theta.F90 (modified) (7 diffs)
• kernels_hex/compute_theta.k90 (added)
• kernels_unst/theta.k90 (modified) (2 diffs)

codes/icosagcm/devel/src/dynamics/caldyn_hevi.f90

@@ -5 +5 @@
   USE caldyn_kernels_hevi_mod
   USE caldyn_kernels_base_mod
-  USE compute_theta_mod, ONLY : compute_theta
+  USE compute_theta_mod, ONLY : compute_theta => compute_theta_manual
   USE compute_caldyn_kv_mod, ONLY : compute_caldyn_kv
   USE compute_caldyn_Coriolis_mod, ONLY : compute_caldyn_Coriolis

codes/icosagcm/devel/src/dynamics/compute_theta.F90

@@ -1 +1 @@
 MODULE compute_theta_mod
-  USE grid_param, ONLY : llm
+  USE grid_param, ONLY : llm, nqdyn
+  USE disvert_mod, ONLY : mass_dak, mass_dbk, caldyn_eta, eta_mass, ptop
   IMPLICIT NONE
   PRIVATE
@@ -6 +7 @@
 #include "../unstructured/unstructured.h90"
 
-  PUBLIC :: compute_theta
+  PUBLIC :: compute_theta_unst, compute_theta_hex, compute_theta_manual
 
 CONTAINS
+
+  ! Python/Fortran differences to be resolved at some point :
+
+  ! the Fortran driver prognoses ps/mass_col or rhodz depending on caldyn_eta
+  ! the Python driver prognoses rhodz even if caldyn_eta==eta_mass
+  ! so that the DOFs are the same whatever caldyn_eta
+
+  ! in the Fortran driver dak, dbk are 1D and based on pressure
+  ! => m = mass_dak(l)+(mass_col(ij)*g+ptop)*mass_dbk(l)
+  !    rhodz(CELL) = m/g 
+  ! in the Python driver dak, dbk are 2D and based on mass
+  ! => rhodz(CELL) = MASS_DAK(CELL) + mass_col(HIDX(CELL))*MASS_DBK(CELL)
 
 #ifdef BEGIN_DYSL
@@ -14 +27 @@
 KERNEL(theta)
   IF(caldyn_eta==eta_mass) THEN ! Compute mass
-    ! FIXME : here mass_col is computed from rhodz
-    ! so that the DOFs are the same whatever caldyn_eta
-    ! in DYNAMICO mass_col is prognosed rather than rhodz
+    ! compute mass_col from rhodz
     SEQUENCE_C1
       PROLOGUE(0)
@@ -27 +38 @@
     FORALL_CELLS_EXT()
       ON_PRIMAL
-        ! FIXME : formula below (used in DYNAMICO) is for dak, dbk based on
-        ! pressure rather than mass
-        !        m = mass_dak(CELL)+(mass_col(HIDX(CELL))*g+ptop)*mass_dbk(CELL)
-        !        rhodz(CELL) = m/g 
         rhodz(CELL) = MASS_DAK(CELL) + mass_col(HIDX(CELL))*MASS_DBK(CELL)
       END_BLOCK
@@ -44 +51 @@
 END_BLOCK
 
+KERNEL(compute_theta)
+  IF(caldyn_eta==eta_mass) THEN ! Compute mass
+     FORALL_CELLS_EXT()
+       ON_PRIMAL
+         m = MASS_DAK(CELL)+(mass_col(HIDX(CELL))*g+ptop)*MASS_DBK(CELL)
+         rhodz(CELL) = m/g
+        END_BLOCK
+     END_BLOCK
+  END IF  
+  DO iq=1,nqdyn
+     FORALL_CELLS_EXT()
+       ON_PRIMAL
+         theta(CELL,iq) = theta_rhodz(CELL,iq)/rhodz(CELL)
+       END_BLOCK
+     END_BLOCK
+  END DO
+END_BLOCK
+
 #endif END_DYSL
 
-SUBROUTINE compute_theta_unst(mass_col,rhodz,theta_rhodz, theta)
-  USE ISO_C_BINDING, only : C_DOUBLE, C_FLOAT
-  USE data_unstructured_mod, ONLY : id_theta,primal_num,dual_num,edge_num, &
-    enter_trace, exit_trace
-  USE grid_param, ONLY : nqdyn
-  USE disvert_mod, ONLY : mass_dak, mass_dbk, caldyn_eta, eta_mass, ptop
-  FIELD_PS :: mass_col
-  FIELD_MASS :: rhodz
-  FIELD_THETA :: theta, theta_rhodz
-  DECLARE_INDICES
-  NUM :: m
-  START_TRACE(id_theta, 3,0,0) ! primal, dual, edge  
+  SUBROUTINE compute_theta_unst(mass_col,theta_rhodz, rhodz,theta)
+    USE ISO_C_BINDING, only : C_DOUBLE, C_FLOAT
+    USE data_unstructured_mod, ONLY : id_theta,primal_num,dual_num,edge_num, &
+         enter_trace, exit_trace
+    FIELD_PS :: mass_col
+    FIELD_MASS :: rhodz
+    FIELD_THETA :: theta, theta_rhodz
+    DECLARE_INDICES
+    NUM :: m
+    START_TRACE(id_theta, 3,0,0) ! primal, dual, edge  
 #define MASS_DAK(l,ij) mass_dak(l)
 #define MASS_DBK(l,ij) mass_dbk(l)
@@ -63 +86 @@
 #undef MASS_DAK
 #undef MASS_DBK
-  STOP_TRACE
-END SUBROUTINE
+    STOP_TRACE
+  END SUBROUTINE compute_theta_unst
 
-  SUBROUTINE compute_theta(ps,theta_rhodz, rhodz,theta)
+  SUBROUTINE compute_theta_hex(mass_col,theta_rhodz, rhodz,theta)
     USE icosa
     USE trace, ONLY : trace_start, trace_end
     USE omp_para, ONLY : ll_begin, ll_end
-    USE disvert_mod, ONLY : mass_dak, mass_dbk, caldyn_eta, eta_mass, ptop
+    REAL(rstd),INTENT(IN)    :: mass_col(iim*jjm)
+    REAL(rstd),INTENT(IN)    :: theta_rhodz(iim*jjm,llm,nqdyn)
+    REAL(rstd),INTENT(INOUT) :: rhodz(iim*jjm,llm)
+    REAL(rstd),INTENT(OUT)   :: theta(iim*jjm,llm,nqdyn)
+    INTEGER :: ij,l,iq
+    REAL(rstd) :: m
+    CALL trace_start("compute_theta")
+#define MASS_DAK(ij,l) mass_dak(l)
+#define MASS_DBK(ij,l) mass_dbk(l)
+#include "../kernels_hex/compute_theta.k90"
+#undef MASS_DAK
+#undef MASS_DBK
+    CALL trace_end("compute_theta")
+  END SUBROUTINE compute_theta_hex
+  
+  SUBROUTINE compute_theta_manual(ps,theta_rhodz, rhodz,theta)
+    USE icosa
+    USE trace, ONLY : trace_start, trace_end
+    USE omp_para, ONLY : ll_begin, ll_end
     REAL(rstd),INTENT(IN)    :: ps(iim*jjm)
     REAL(rstd),INTENT(IN)    :: theta_rhodz(iim*jjm,llm,nqdyn)
@@ -99 +140 @@
 
     CALL trace_end("compute_theta")
-  END SUBROUTINE compute_theta
+  END SUBROUTINE compute_theta_manual
   
 END MODULE compute_theta_mod

codes/icosagcm/devel/src/kernels_unst/theta.k90

@@ -2 +2 @@
    !---------------------------- theta ----------------------------------
    IF(caldyn_eta==eta_mass) THEN ! Compute mass
-      ! FIXME : here mass_col is computed from rhodz
-      ! so that the DOFs are the same whatever caldyn_eta
-      ! in DYNAMICO mass_col is prognosed rather than rhodz
+      ! compute mass_col from rhodz
       !$OMP DO SCHEDULE(STATIC)
       DO ij=1,primal_num
@@ -17 +15 @@
          !DIR$ SIMD
          DO l = 1, llm
-            ! FIXME : formula below (used in DYNAMICO) is for dak, dbk based on
-            ! pressure rather than mass
-            ! m = mass_dak(l,ij)+(mass_col(ij)*g+ptop)*mass_dbk(l,ij)
-            ! rhodz(l,ij) = m/g
             rhodz(l,ij) = MASS_DAK(l,ij) + mass_col(ij)*MASS_DBK(l,ij)
          END DO