Changeset 1015 for codes/icosagcm/trunk/src/time

Timestamp:

02/28/20 10:18:33 (4 years ago)

Author:

ymipsl

Message:

1j+1j=2j

• the iteration frequency of syncronization procedure at frontier (every 10 time step before) must be a sub multiple of the restart period (daily). So we fix itau_sync to be close of 10 and be a sub multiple of number of iteration in a day.
• The value of rhodz for advection must be recomputed at a sub-multiple multiple of the restart period, so for now we decide to recomputing it each time at the end of the advection.

YM

File:

• codes/icosagcm/trunk/src/time/timeloop_gcm.F90 (modified) (8 diffs)

codes/icosagcm/trunk/src/time/timeloop_gcm.F90

@@ -11 +11 @@
   PRIVATE
   
-  INTEGER, PARAMETER :: itau_sync=10
+  INTEGER, PARAMETER :: sync_it=10
   TYPE(t_message),SAVE :: req_ps0, req_mass0, req_theta_rhodz0, req_u0, req_q0, req_W0, req_geopot0
   LOGICAL, SAVE :: positive_theta
@@ -203 +203 @@
     LOGICAL, PARAMETER :: check_rhodz=.FALSE.
     INTEGER(kind=8) :: start_clock, stop_clock, rate_clock
+    INTEGER :: itau_sync   ! best iteration for synchronisation and ensure 1+1=2
+    INTEGER :: i
+    
     LOGICAL,SAVE :: first_physic=.TRUE.
     !$OMP THREADPRIVATE(first_physic)    
 
+    itau_sync=1
+    DO i=2,3*sync_it
+      IF (MOD(86400,INT(i*dt))==0 .AND. ABS((sync_it-itau_sync)*1./sync_it )/sync_it < (sync_it-itau_sync)*1./sync_it) itau_sync=i
+    ENDDO
+    IF (is_master) PRINT*,"Synchronize frontier every itau_sync =",itau_sync
+      
     CALL switch_omp_distrib_level
     CALL caldyn_BC(f_phis, f_geopot, f_wflux) ! set constant values in first/last interfaces
@@ -261 +270 @@
 
     DO it=itau0+1,itau0+itaumax
+
        CALL print_iteration(it, itau0, itaumax, start_clock, rate_clock)
 
@@ -272 +282 @@
        END IF
 
-       IF (it==itau0+1 .OR. MOD(it,itau_sync)==0) THEN
+       IF (it==itau0+1 .OR. MOD(it-1,itau_sync)==0) THEN
           CALL send_message(f_ps,req_ps0)
           CALL wait_message(req_ps0)
@@ -291 +301 @@
        ENDIF
 
+!       CALL checksum(f_ps)
+!       CALL checksum(f_theta_rhodz)
+!       CALL checksum(f_u)
+!       CALL checksum(f_q)
+!       CALL checksum(f_mass)
+!       CALL checksum(f_geopot)
+!       CALL checksum(f_rhodz)
+!       CALL checksum(f_wflux)
+
        CALL guided(it*dt,f_ps,f_theta_rhodz,f_u,f_q)
 
@@ -302 +321 @@
        END SELECT
        CALL exit_profile(id_dyn)
+
+!       CALL checksum(f_ps)
+!       CALL checksum(f_theta_rhodz)
+!       CALL checksum(f_u)
+!       CALL checksum(f_q)
+!       CALL checksum(f_mass)
+!       CALL checksum(f_geopot)
+!       CALL checksum(f_rhodz)
+!       CALL checksum(f_wflux)
 
        CALL enter_profile(id_dissip)
@@ -338 +366 @@
        END IF
        CALL exit_profile(id_dissip)
+!       CALL checksum(f_ps)
+!       CALL checksum(f_theta_rhodz)
+!       CALL checksum(f_u)
+!       CALL checksum(f_q)
+!       CALL checksum(f_hfluxt)
+!       CALL checksum(f_wfluxt)
+!       CALL checksum(f_u)
+!       CALL checksum(f_rhodz)
 
        CALL enter_profile(id_adv)
@@ -349 +385 @@
           IF(diagflux_on) CALL diagflux_energy(adv_over_out, f_phis,f_rhodz,f_theta_rhodz,f_u, f_geopot,f_theta,f_buf_i, f_hfluxt)
 
-          IF (check_rhodz) THEN ! check that rhodz is consistent with ps
-             DO ind=1,ndomain
-                IF (.NOT. assigned_domain(ind)) CYCLE
-                CALL swap_dimensions(ind)
-                CALL swap_geometry(ind)
-                rhodz=f_rhodz(ind); ps=f_ps(ind);
-                CALL compute_rhodz(.FALSE., ps, rhodz)   
-             END DO
-          ENDIF
+          DO ind=1,ndomain
+            IF (.NOT. assigned_domain(ind)) CYCLE
+            CALL swap_dimensions(ind)
+            CALL swap_geometry(ind)
+            rhodz=f_rhodz(ind); mass=f_mass(ind); ps=f_ps(ind)
+            IF(caldyn_eta==eta_mass) THEN
+              CALL compute_rhodz(.TRUE., ps, rhodz, ondevice=.TRUE.) ! save rhodz for transport scheme before dynamics update ps
+            ELSE
+              DO l=ll_begin,ll_end
+                 rhodz(:,l)=mass(:,l)
+              ENDDO
+            END IF
+          END DO
+
           IF(positive_theta) CALL abort_acc("positive_theta")
           IF(positive_theta) CALL copy_q_to_theta(f_theta_rhodz,f_rhodz,f_q)
        END IF
        CALL exit_profile(id_adv)
+!       CALL checksum(f_ps)
+!       CALL checksum(f_theta_rhodz)
+!       CALL checksum(f_u)
+!       CALL checksum(f_q)
 
        CALL enter_profile(id_diags)